[sema] reject inline as { ... } on opaque source types#747
Closed
[sema] reject inline as { ... } on opaque source types#747
Conversation
Owner
Author
|
closed without merge — stale CI check statuses from cancelled parallel runs prevented merge. reopened as #748 with a clean single-commit branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
(x as unknown as { type: string; value: number })silently passed the type-assertion prefix checker because there's no source interface to compare against. In native code, the inline fields become GEP indices — if they don't match the actual struct layout, it reads wrong memory.After
Compile error when an inline
as { ... }assertion (2+ fields) follows anas unknown,as any, oras objectintermediate cast. Suggests usingas NamedInterfaceinstead.Description
Extends
type-assertion-checker.tswith a newcheckOpaqueSourcemethod. This was the last unaccounted-for hazard in the "Patterns That Crash" list — inlineas { ... }on opaque-typed sources where the prefix checker has nothing to verify against. ~30 LOC.Closes item #3 from #729.
Next Steps